Make pay repeat on routing failure - #993
Merged
Merged
Conversation
In preparation for separating `pay` algorithm from `sendpay`.
ZmnSCPxj
changed the title
pay repeat on routing failurepay repeat on routing failure
Contributor
|
This seems quite useful. I tried making a payment to mainnet Yalls using this PR and got Making a donation to Recksplorer did work after 6 (automated) tries (on master it usually fails). |
cdecker
reviewed
Feb 15, 2018
cdecker
left a comment
cdecker
left a comment
Member
There was a problem hiding this comment.
Excellent patchset as always @ZmnSCPxj, I'll let @rustyrussell merge this once he had a chance to review as well.
ACK 02ba654
| * no longer be called. */ | ||
| static struct sendpay_command * | ||
| new_sendpay_command(struct command *cmd, | ||
| new_sendpay_command(const tal_t *cxt, |
Member
|
ACK 02ba654 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #863
send_paymentinternal interface.paycommand handling to a newlightning/payalgo.csystem.payrepeat.Intent is to make improvements to pay algorithm in the future to become easier:
from_idparameter ofgetroute.